Git Product home page Git Product logo

Comments (11)

lloesche avatar lloesche commented on August 15, 2024 2

@armanatz oh I was referring to V+. I had created an issue valheimPlus/ValheimPlus#58 which is resolved and says that data rate modification will be included with V+ v0.8.5. So no extra work for you 🎉 🙂

from valheim-server-docker.

lloesche avatar lloesche commented on August 15, 2024

This is covered by the work in #63 which also uses BepInEx.

See #58 for how we're currently solving it manually.

from valheim-server-docker.

armanatz avatar armanatz commented on August 15, 2024

@lloesche The work that I am doing in #63 is currently focused on getting Valheim Plus to work well and keep the behaviors of this Docker image intact; namely auto updates and Steam validation.

However, because of that, I am not sure if the current iteration of my work can be used to support other mods as I hadn't planned for it. Once my PR is submitted, we can discuss how to extend the BepInEx in the Docker image to also support other drop in mods.

What do you think?

from valheim-server-docker.

wedol avatar wedol commented on August 15, 2024

Instead adding support for specific mods, it will be better to add generic support for mods (via BepInEx) and expose volume for plugins.

from valheim-server-docker.

lloesche avatar lloesche commented on August 15, 2024

@wedol thank you for the suggestion!
@armanatz what do you think? I only just now looked into BepInEx. I wasn't aware that ValheimPlus is a collection of plugins that all base on BepInEx. Would it make more sense to add generic BepInEx support and then maybe have a switch "Add all ValheimPlus" plugins? That way users could use a curated preselection (Valheim Plus) but also add their own modifications.
Sounds cleaner to me.

from valheim-server-docker.

armanatz avatar armanatz commented on August 15, 2024

@lloesche It was an idea I was mulling over. However, there are a few considerations we'd need to take into account:

  1. So BepInEx alone is not enough to run mods. We would also need unstripped Unity DLLs in order for Doorstop to not crash on startup of Valheim Server (see NeighTools/UnityDoorstop#10 for more info). These DLLs come pre-shipped with V+ which makes it a more verifiable source than the one in the GitHub ticket I linked.
  2. V+ ships with it's own BepInEx.cfg file which will override the one that BepInEx generates. I am not sure if the configuration is different from the defaults
  3. Should we go with this method, how do we ensure that the mods are not overridden by updates? Since we are only accounting for V+ at the moment, it is easy to auto-update both the game and the mod.

I think one way to tackle a lot of these changes is to use V+ as the base mod and all other mods can then be installed on top of it. However, I am not sure how some mods may interact with V+ and that could cause conflicts and errors to occur

from valheim-server-docker.

Morgul avatar Morgul commented on August 15, 2024

I think one way to tackle a lot of these changes is to use V+ as the base mod and all other mods can then be installed on top of it. However, I am not sure how some mods may interact with V+ and that could cause conflicts and errors to occur

Might it make sense to roll out mod support in stages? As a first pass, do this, with the caveat of "beware mod interactions with V+, as we use it as the base mod". Then, look into more full-featured general mod support?

from valheim-server-docker.

Toucan-Sam avatar Toucan-Sam commented on August 15, 2024

I'm keen on V+ because reasons, but as far as support in this container, I don't have objections with there being some arbitrary level of knowledge required to install/manage them.

IF MOD_SUPPORT = TRUE, THEN install BepInEx AND configure executable_name=""; AND launch game via ./run_bepinex.sh
IF MOD_SUPPORT = FALSE (default), THEN launch game via steam_cmd.

Long as the required directories are symlink'd to an external volume/mount that should be enough?

PS, BepInEx goes in folder. -> ??? -> Success!
I have no idea how BepInEx works so this might not even viable. I just don't think this container should be overly concerned with mod incompatibilities. That's not what the container does.

from valheim-server-docker.

brcoding avatar brcoding commented on August 15, 2024

BepInEx hooks the executable on startup, if there are no plugins to load, it does nothing. It is usually no big deal to just have it run and then you can drop in files in whatever the configured folder is.

from valheim-server-docker.

lloesche avatar lloesche commented on August 15, 2024

If you guys would like to test ValheimPlus support you can use the dev tag of the Docker image lloesche/valheim-server:dev

Updated README is here https://github.com/lloesche/valheim-server-docker/tree/dev

Let us know in #91 if everything works.

Thanks to all testers!

from valheim-server-docker.

lloesche avatar lloesche commented on August 15, 2024

ValheimPlus support is now in the main branch.

from valheim-server-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.