Comments (10)
Other hiopVectorPar
reduction kernels that perform local, but not global (MPI) reduction:
fractionToTheBdry
fractionToTheBdry_w_pattern
isnan
isinf
isfinite
from hiop.
correct, this is because the calling code performs the interprocess comm for better performance.
I suggest we suffix with _local
all these functions. Also linearDampingTerm
falls in the same category
from hiop.
CC: @ashermancinelli
from hiop.
Also, it seems projectIntoBounds
performs local reduction only, no MPI call.
from hiop.
To summarize - these vector class methods perform only local reduction:
logBarrier
linearDampingTerm
projectIntoBounds
fractionToTheBdry
fractionToTheBdry_w_pattern
isnan
isinf
isfinite
I will document them in GPU portable branch, but will not change function names for now.
from hiop.
Do we ever intend to have globally reducing versions of these functions seeing as the calling code ought to perform the reduction for performance reasons? If not, suffixing with _local
may be redundant and documenting the responsibilities of the methods ought to be enough.
tldr if we're never going to have globally reducing versions of these functions, I think the names should stay the same and we should just better document/test them.
from hiop.
likely not, but I still think they should be suffixed. It's going to be just a hell more clear that there is no communic...
from hiop.
SGTM
from hiop.
on my to do list
from hiop.
closing ... commit a0074ae addresses this.
from hiop.
Related Issues (20)
- Update CMake files for building HiOp and LiDO in co-develop mode
- Introduce more user parameters to control NLP scaling
- Update Ginkgo interface so it can take data directly on GPU HOT 1
- Narrowing conversion in Ginko HOT 7
- Install Ginkgo via Spack for HiOp HOT 1
- Primal regularizations for x and d are different
- Failure from the feasibility restoration
- `hiop~mpi` includes MPI headers HOT 6
- Segmentation fault when copying empty matrix in sparse GPU mode
- `hiop@develop%clang-rocm` unable to build HOT 5
- Hiop fails to build on Frontier with Exago build script from KPP2
- `hiop+cuda ^cuda@12` failes to build HOT 7
- Build with Strumpack enabled fails due to -Werror (`-Werror=unused-variable`, `-Werror=reorder`) HOT 4
- RAJA must be used when CUDA is selected. HOT 2
- Are versions retagged? HOT 4
- Cannot build with CUDA flag set ON HOT 3
- Update Incline CI to use ROCm 5.6.0/6.0.0 HOT 1
- Derivative checker
- Add advanced checkpoint/restart capabilities to Hiop
- Set up a GHCR Spack build cache to speed up spack pipelines
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hiop.