Git Product home page Git Product logo

Comments (10)

pelesh avatar pelesh commented on August 18, 2024

Other hiopVectorPar reduction kernels that perform local, but not global (MPI) reduction:

  • fractionToTheBdry
  • fractionToTheBdry_w_pattern
  • isnan
  • isinf
  • isfinite

from hiop.

cnpetra avatar cnpetra commented on August 18, 2024

correct, this is because the calling code performs the interprocess comm for better performance.

I suggest we suffix with _local all these functions. Also linearDampingTerm falls in the same category

from hiop.

pelesh avatar pelesh commented on August 18, 2024

CC: @ashermancinelli

from hiop.

pelesh avatar pelesh commented on August 18, 2024

Also, it seems projectIntoBounds performs local reduction only, no MPI call.

from hiop.

pelesh avatar pelesh commented on August 18, 2024

To summarize - these vector class methods perform only local reduction:

  • logBarrier
  • linearDampingTerm
  • projectIntoBounds
  • fractionToTheBdry
  • fractionToTheBdry_w_pattern
  • isnan
  • isinf
  • isfinite

I will document them in GPU portable branch, but will not change function names for now.

from hiop.

ashermancinelli avatar ashermancinelli commented on August 18, 2024

Do we ever intend to have globally reducing versions of these functions seeing as the calling code ought to perform the reduction for performance reasons? If not, suffixing with _local may be redundant and documenting the responsibilities of the methods ought to be enough.

tldr if we're never going to have globally reducing versions of these functions, I think the names should stay the same and we should just better document/test them.

from hiop.

cnpetra avatar cnpetra commented on August 18, 2024

likely not, but I still think they should be suffixed. It's going to be just a hell more clear that there is no communic...

from hiop.

ashermancinelli avatar ashermancinelli commented on August 18, 2024

SGTM

from hiop.

cnpetra avatar cnpetra commented on August 18, 2024

on my to do list

from hiop.

cnpetra avatar cnpetra commented on August 18, 2024

closing ... commit a0074ae addresses this.

from hiop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.