Using a newer Intel compiler on the develop branch causes a couple of tests to fail. I

Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-u

Test failure with newer Intel compiler about conduit HOT 3 CLOSED

BradWhitlock commented on June 13, 2024

Test failure with newer Intel compiler

from conduit.

Comments (3)

ChristosT commented on June 13, 2024

I stumbled upon this recently.
When it comes to t_conduit_node_compare here are my findings:

It happens only on float types.
-fp-model=precise does not help
One solution is to modify how the " Leaf Difference Test " modifies the array elements and set more that 1 bytes.

From 694f70f9960682a298fe451fbbf061f24e176d92 Mon Sep 17 00:00:00 2001
From: Christos Tsolakis <[email protected]>
Date: Fri, 15 Dec 2023 00:46:58 +0000
Subject: [PATCH] t_conduit_node_compare: Apply memset to full size of element

fixes comparison failure with Intel compilers
---
 src/tests/conduit/t_conduit_node_compare.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/tests/conduit/t_conduit_node_compare.cpp b/src/tests/conduit/t_conduit_node_compare.cpp
index d60a136d..8de2624c 100644
--- a/src/tests/conduit/t_conduit_node_compare.cpp
+++ b/src/tests/conduit/t_conduit_node_compare.cpp
@@ -137,8 +137,8 @@ TEST(conduit_node_compare, compare_leaf_numeric)

             { // Leaf Difference Test //
                 Node info;
-                memset(o.element_ptr(0), 1, 1);
-                memset(o.element_ptr(4), 1, 1);
+                memset(o.element_ptr(0), 1, o.dtype().element_bytes());
+                memset(o.element_ptr(4), 1, o.dtype().element_bytes());
                 EXPECT_TRUE(diff_nodes(n, o, info));

                 Node &info_diff = info["value"];
-- 
2.27.0

tested using intel compiler 2023.0.0 (icc (ICC) 2021.8.0 20221119)

from conduit.