Git Product home page Git Product logo

Comments (1)

rcarson3 avatar rcarson3 commented on September 28, 2024

@white238 I've recently run into this issue for some of my pure C++ libraries I manage when I moved to newer versions of BLT and my HIP testing of them. Would you be open to accepting a patch for the v0.6.x release branch that fixes this bug by adding a guards around it by something like this in BLTOptions.cmake:

set(_c_already_enabled FALSE)
foreach(enabled_langs IN LISTS _languages)
   string(COMPARE EQUAL "${enabled_langs}" "C" _c_already_enabled)
   if (_c_already_enabled)
    break()
   endif()
endforeach()

and then around the above:

    if(_c_already_enabled)
            blt_add_executable(NAME blt_hip_runtime_c_smoke
                        SOURCES blt_hip_runtime_c_smoke.c
                        OUTPUT_DIR ${TEST_OUTPUT_DIRECTORY}
                        DEPENDS_ON blt::hip_runtime
                        FOLDER blt/tests )

        blt_add_test(NAME blt_hip_runtime_c_smoke
                    COMMAND blt_hip_runtime_c_smoke)
    endif()

Since,I'm not the best cmake person, it might need more refining, but I've found that at least in my local testing of an SNLS branch with the above patch in v0.6.2 of BLT that this fixes the cmake failures I was seeing on my HIP builds.

Also, it appears that GTest does require a C compiler, so I still need to supply a C compiler in places even if my project is purely C++ :/

from blt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.