Comments (1)
@white238 I've recently run into this issue for some of my pure C++ libraries I manage when I moved to newer versions of BLT and my HIP testing of them. Would you be open to accepting a patch for the v0.6.x release branch that fixes this bug by adding a guards around it by something like this in BLTOptions.cmake:
set(_c_already_enabled FALSE)
foreach(enabled_langs IN LISTS _languages)
string(COMPARE EQUAL "${enabled_langs}" "C" _c_already_enabled)
if (_c_already_enabled)
break()
endif()
endforeach()
and then around the above:
if(_c_already_enabled)
blt_add_executable(NAME blt_hip_runtime_c_smoke
SOURCES blt_hip_runtime_c_smoke.c
OUTPUT_DIR ${TEST_OUTPUT_DIRECTORY}
DEPENDS_ON blt::hip_runtime
FOLDER blt/tests )
blt_add_test(NAME blt_hip_runtime_c_smoke
COMMAND blt_hip_runtime_c_smoke)
endif()
Since,I'm not the best cmake person, it might need more refining, but I've found that at least in my local testing of an SNLS branch with the above patch in v0.6.2 of BLT that this fixes the cmake failures I was seeing on my HIP builds.
Also, it appears that GTest does require a C compiler, so I still need to supply a C compiler in places even if my project is purely C++ :/
from blt.
Related Issues (20)
- BLT v0.5.3 has some build errors related to googletest HOT 7
- Create tutorial for static analysis and friends
- Modify behavior of `blt_list_append` ?
- CMake Install Logic Checklist
- bug: setting ENABLE_CLANG_CUDA and BLT_CXX_STD=c++17 causes error
- Missing case in `blt_patch_target` and `blt_determine_scope`
- Compiler error with gcc+hip
- Override system include flag when necessary
- Add support for `fpreffity` fortran formatter
- `blt_check_code_compiles`: Work around `try_compile` not working with ALIAS targets
- google test finds python undermining ability to find python you want HOT 3
- Use of ALIAS target magic requires newish cmake
- blt cuda setup issue with newer cmake? HOT 7
- add target_compile_features option / plumbing to blt_add_library
- incrementally add sources + headers to lib using blt HOT 2
- blt_add_yapf_target requires a SRC_FILES parameter HOT 4
- Setting `CMAKE_RUNTIME_OUTPUT_DIRECTORY` causing duplicate exec issues when building MFEM with Ninja HOT 6
- fortran vs mpi logic
- SetupCompilerOptions erroneously classifies "CrayClang" as "Clang"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blt.