Comments (7)
ah I believe that actually just needs an additional flag, let me introduce that
from eslint-config-galex.
should be fixed with enableJavaScriptSpecificRulesInTypeScriptProject
in the next release I hope :) docs included https://github.com/ljosberinn/eslint-config-galex#features
from eslint-config-galex.
great idea, yeah!
would need to extract:
- createPossibleErrorRules -> typescript
- createBestPractices -> typescript
- createVariableRules -> typescript
- createStylisticIssuesRules -> typescript, CRA, Next
- createES6Rules -> typescript
from eslint-config-galex.
should be fixed with the next release, lmk :)
from eslint-config-galex.
Hmm, it seems that the new behaviour is not quite what I expected since my JS files are still not fully linted. They do get fully linted if I enable checkJs
, but as mentioned, this is not doable in my project.
The error is mine: checkJs
has nothing to do with the issue at hand. Obviously, ESLint only cares about the *.ts
glob! It doesn't magically apply the TS override to JS files when checkJs
is enabled... Silly me! 😓
So I think the solution is for the new override that disables rules with TS equivalents to only ever apply to TS files -- never to JS files, regardless of checkJs
.
If this leads to too many errors in a legacy project, then this is a good use case for your incrementalAdoption
feature (which I haven't had time to look into yet but sounds very promising).
from eslint-config-galex.
I've just upgraded, and it works great, thanks a lot! 🎉
from eslint-config-galex.
As a side benefit, it now also fully lints all the .eslintrc.js
, vite.config.js
and other jest.config.js
files in my monorepo 😄
from eslint-config-galex.
Related Issues (20)
- Consider eslint-plugin-css-modules
- Integrate the important parts of `@remix/eslint-config` HOT 1
- Dependency Dashboard
- evaluate eslint-plugin-etc HOT 1
- fix readme HOT 1
- fix no-unreadable-array-destructuring HOT 1
- TS error with `createConfig` HOT 6
- `getDependencies` called twice HOT 2
- initial v5 plans HOT 3
- Support Next 13 HOT 13
- Could `import/order` be replaced with `simple-import-sort`? HOT 2
- Clarify reasons for disabling TS rules (and consider re-enabling some) HOT 1
- lodash.merge doesn't actually merge appropriately
- jest/unbound-method throws in CRA due to not being properly set up
- Slow rule
- [Prettier compat] format may return Promise
- [jest rules] unbound-method needs parserOptions.project set
- v5 HOT 1
- Consider `eslint-plugin-react-refresh`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-config-galex.