Git Product home page Git Product logo

Comments (6)

ljlm0402 avatar ljlm0402 commented on May 16, 2024

@AshotN

There is no particular reason. I think the way you speak is good. Thank you for your pull request.

from typescript-express-starter.

ragrag avatar ragrag commented on May 16, 2024

i think having non-static classes is much better out of the box for dependency injection of them and of other services/instances inside them without playing much around with IoC Containers

from typescript-express-starter.

AshotN avatar AshotN commented on May 16, 2024

Feel free to close this issue if you believe that there is no need to change anything.

from typescript-express-starter.

ljlm0402 avatar ljlm0402 commented on May 16, 2024

@ragrag

Thank you very much for the comment.
If so, is that open source well organized? Sorry. I speak English with a translator incorrectly.

from typescript-express-starter.

ragrag avatar ragrag commented on May 16, 2024

@ljlm0402
I would consider it very organized however there are a couple of suggestions i would like to propose.

  1. Having a separate file responsible for bootstrapping the database connection/initialization. (and associations in case of sequelize)
    image

  2. Having a flag or an option in the CLI to structure the project by entities/components instead of technical roles as shown in the image:
    image
    Please see: https://github.com/goldbergyoni/nodebestpractices/blob/master/sections/projectstructre/breakintcomponents.md

from typescript-express-starter.

ljlm0402 avatar ljlm0402 commented on May 16, 2024

@ragrag

Thanks for the good suggestions and detailed explanations.
It was very helpful. We will try to reflect it after review.

from typescript-express-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.