Sunshine doesn't handle missing libminiupnpc.so, which should be treated as an optional dependency about sunshine HOT 5 CLOSED

The dependency is required, as intended.

from sunshine.

Would you care to explain more? I went through docs last week and don't recall any of this. Also, as said in OP, UPnP is disabled by default in Sunshine. And secondly, you simply cannot rely on users' networks to offer this service.

So why would it be required?

from sunshine.

It's disabled by default, but the dependency is required in case the option is enabled.

Making the dependency optional, will make things unnecessarily complicated. Then we would have to provide a different UI to users who don't have the dependency, versus those who do?

We have enough actual bugs to deal with, without introducing unnecessary changes.

from sunshine.

I understand, especially since we're at somewhat early stages of development. However, reducing dependencies is still a welcome improvement that could be addressed in the long run. Hopefully Sunshine is here to stay and someday there will be time to polish even such minor issues. Please reconsider reopening this and tagging it for the long run.

from sunshine.

If this were CUDA, that would be a legitimate concern. miniupnpc is 131 KB in size. There isn't much to gain from making this optional, but there's a lot of potential downsides.

from sunshine.