Comments (14)
When hit with the File is ambiguous in this context
, I resolved it by adding the following import statement:
import struct S3.File
from s3.
I strongly suggest to rename File
to slomething else like S3File
, FileObject
, S3Object
or anything else. What do you think @rafiki270?
Right now it collides with Vapor directly, and it can collide with so many more libraries...
from s3.
Renaming File to S3File sounds like the best option to me.
from s3.
I believe renaming the S3 class so it doesn't bear the name of the package. It is a bad practise (which I wasn't aware of at the time of making the library) for the reasons of being unable to namespace.
Regarding the struct names, I strongly support the most obvious names even if a possible conflict with a sister package is available.
I will be back in the coding den next week and will make the change unless someone would like to help and make a PR beforehand?
from s3.
So what will the new name for the S3 File class be?
from s3.
File ... but you will be able to do S3.File to namespace as S3 won't be the name of the client but the package
from s3.
Perfect.
from s3.
What name would you like it to have? S3Client
, S3Api
? Please dont say Client
:D :D
from s3.
Just Client
... S3Client
is already a protocol which would probably deserve a rename as well tbh
from s3.
We will have again conflict with Vapor then :/
from s3.
We won't as we'll be able to namespace
from s3.
Client, File, Object ... all of that should be possible in any package ... you don't have to name your objects with prefixes just to make sure someone's else lib won't conflict with your naming conventions like we did in ObjC
from s3.
I do understand and agree most of the times. They are not package prefixes. For me they are specialozation in this case. You are clearly static that it is S3 client or file. But, I agree with you as this is S3 package only.
from s3.
Any News?
from s3.
Related Issues (20)
- Files being referenced by URL are not working Linux Issue HOT 2
- Presigned URL returns 403 HOT 7
- Dependencies still appear to be off HOT 14
- Issue with RC tag names HOT 2
- `get` and `delete` cache issue? HOT 12
- File.Upload - cannot assign region
- list - allow using prefix and delimiter parameters
- CI builds fail
- Version tag collision HOT 1
- Conform S3.Error to AbortError Protocol HOT 2
- Please tag new release
- Listing an Empty Bucket causes an Error
- Problem with package version in packages.swift
- Wrong service configuration in readme
- Uploading fails on Linux/Docker in production mode HOT 10
- XAmzContentSHA256Mismatch HOT 2
- s3.location returns buggy Region for us-west-1
- 'HTTPURLResponse' is unavailable HOT 3
- Support for Vapor4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from s3.