Git Product home page Git Product logo

Comments (1)

bennieboj avatar bennieboj commented on July 30, 2024

This only happens if the user manually edits data.sql right?
The creds, server.ini and data.sql are already backed up on the host, since they are inside the 3 volumes?
Or am I missing something, if so please correct me.

Although I do agree that we should prevent this from happening, never underestimate users etc...

  1. We could compare creds, server.ini and data.sql and if there is a difference just regenerate new creds using the existing script.

  2. Also I noticed that the server stores the game servers inside the public.teams and the public.users tables. While this isn't a big issue, it isn't entirely clean either as the db will grow bigger. We probably should remove all the ones that are not in the current creds/server.ini.

One could argue to just do complete removal of all creds in data.sql and recreation of new creds at every boot of the server? That way we don't have to make annoying parsing and compare code which is bound to fail anyhow if users interact with the files. By doing so we hit two birds with one stone so to speak.

I got this solution ready if you think this is the way to go. I'm not entirely sure of the implications as I still need to test it this weekend, but I think it should be fine. I'll make a pull request once it's tested :)

from pwnadventure3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.