Git Product home page Git Product logo

Comments (11)

fbiville avatar fbiville commented on August 25, 2024

Thanks for the report!

-p works interactively, and is used as follows:

  1. liquigraph -c /my/changelog.xml -g jdbc:neo4j://my.host:7474 -u myUser -p
  2. a prompt appears: you must type your password (it remains hidden)

If I understand well, you would like to have a non-interactive password parameter?

from liquigraph.

fbiville avatar fbiville commented on August 25, 2024

If so, we could adapt step 1 to also support the following execution:

echo "my_password" | liquigraph -c /my/changelog.xml -g jdbc:neo4j://my.host:7474 -u myUser -p

It would require a tweak to the existing shell script (and possibly Batch one).
And probably something with JCommander too.

What do you think? Would you like to push a change? :-)

from liquigraph.

airomega avatar airomega commented on August 25, 2024

Yeah - effectively I want to be able to do:
liquigraph -c /my/changelog.xml -g jdbc:neo4j://my.host:7474 -u myUser -p password

Happy to take a look at the code and contribute. I'm an recovering java dev and current go coder - it'll take me a while to set up a java env again :o)

from liquigraph.

fbiville avatar fbiville commented on August 25, 2024

Just a JDK 7 and Maven 3.x is enough :-)
Feel free to reach me if you have any questions 👍

from liquigraph.

airomega avatar airomega commented on August 25, 2024

To get my required functionality is a fairly small easy change.

The issue I raised relates to the (password = true) jcommander annotation on the password field in LiquigraphCli (doc:http://jcommander.org/#Types_of_options). If I remove the (password = true) it connects to neo4j and liquigraph can run in the changeset using:

liquigraph -c /my/changelog.xml -g jdbc:neo4j://my.host:7474 -u myUser -p password

Obviously I don't want to push this in as it would likely break other peoples installations/setups. What would your preferred approach be? New flag?

from liquigraph.

fbiville avatar fbiville commented on August 25, 2024

I need to dig a little more into JCommander sources to see if I can get a conditionally interactive parameter. I like the current password behaviour: password remains hidden and out of shell history. But your usecase is also 100% legit and we need a configurable behaviour for that.

from liquigraph.

fbiville avatar fbiville commented on August 25, 2024

Good news! I found a way that requires no code change and does not compromise your password.
Just run:

 $> touch my_password.txt
 # write your password there + chmod appropriately ;-)
 $> liquigraph -c /path/to/changelog.xml -g jdbc:neo4j://localhost:7474 -u my_user -p < my_password.txt

Would you like to send a Pull Request (see gh-pages branch) to update the documentation to reflect this?

from liquigraph.

airomega avatar airomega commented on August 25, 2024

Great. That works. Thanks for that.

I don't mind changing the documentation but I can't see it :D apologies it's probably in a really obvious place.

from liquigraph.

fbiville avatar fbiville commented on August 25, 2024

The online documentation is here.
The documentation sources are here.

You can simply open the local index.html to see your changes.

from liquigraph.

airomega avatar airomega commented on August 25, 2024

Cheers. Done. Let me know if there's any issues.

I'd be happy to include information on how we dockerized liquigraph too if wanted.

from liquigraph.

fbiville avatar fbiville commented on August 25, 2024

Would you mind sending me a Twitter DM? I'm curious about what you did :-)

from liquigraph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.