Git Product home page Git Product logo

Comments (2)

stevesaliman avatar stevesaliman commented on August 29, 2024 1

The Liquibase Maven plugin appears to have a different source file for each target the plugin supports. Each target can then do whatever it wants to do before invoking Liquibase itself. It is worth noting that the Maven plugin is part of the core Liquibase repository, and maintained by the same person.

The Gradle plugin took a different approach. My goal was to have the plugin be a thin wrapper around the command line execution of Liquibase. I wanted to simply pass through any elements of an activity to Liquiabse with as little processing as possible. If Liquibase ever adds or changes command line options, users could simply fix their build.gradle files. No plugin release would be required.

I don't think having 2 different activities is that ugly - one activity is used for changing a single database, and the second involves multiple databases. The property duplication can be minimized by using Gradle properties, like your example does with the changeLogFile.

I'm not completely opposed to adding this, but I want to minimize the amount of work that would need to be done, and the number of things that need to be checked when new versions of Liquibase are released.

from liquibase-gradle-plugin.

atomfrede avatar atomfrede commented on August 29, 2024

Makes totally sense what you say. It is not that ugly but at first I found it quite confusing if you configure e.g. excludeObjects the execution will fail for certain liquibase commands that don't support it. So I am ok to with the current approach and of course there is still some optimization possible on our side. So lets close it and maybe revisit it if needed.

from liquibase-gradle-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.