as_sql() got an unexpected keyword argument 'subquery' about django-pyodbc HOT 5 CLOSED

Hi Ben! Thanks for the report. I'd be happy to merge a PR. Have you tested this change with older versions of Django? Thanks!

from django-pyodbc.

I haven't checked with other versions but can easily do a 'git blame' to find out what version of Django added that argument. In our environment we are doing a huge leap from django 1.6 to 1.10 hence discovering this problem.

Is there a minimum version of django you want to keep django-pyodbc compatible with? I could recode this passing **kwargs instead of an explicit argument so that it would have more backward compatibility...

Thanks!

from django-pyodbc.

Hi Dan, having looked a little more into this now it unfortunately not that simple.. this particular method was changed in django 1.8, then changed BACK in django 1.11.. so django-pyodbc is broken with django 1.8, 1.9, and 1.10 but now isn't broken anymore due to them undoing the change in django.

So although this particular problem disappears in 1.11, if it's desired for django-pyodbc to retain compatibility with 1.8-1.10 then it would be necessary to change this patch to use **kwargs so that it will pass the extra arguments if they are present, and if not, do nothing.

If that's ok with you.

from django-pyodbc.

Based on @benmehlman comment and lack of other comments I am closing this ticket and taggit it "wont-fix". If this is an unacceptable outcome, please put your comments below.

from django-pyodbc.

Merged in #145, thanks @benmehlman for the patch!

from django-pyodbc.