Flipper Extension Breaking on Cinnamon 3.4 about cinnamon-spices-extensions HOT 8 CLOSED

I'm not on 3.4 right now. Can you delete the let in this line https://github.com/linuxmint/cinnamon-spices-extensions/blob/master/Flipper%40connerdev/files/Flipper%40connerdev/extension.js#L37 and check if it solves your issue.

from cinnamon-spices-extensions.

@ConnerHansen

from cinnamon-spices-extensions.

Tried it, no dice. :/

error t=2017-05-11T22:26:52Z redeclaration of let _
error t=2017-05-11T22:26:52Z [Extension "Flipper@connerdev"]: Error importing extension.js from Flipper@connerdev
error t=2017-05-11T22:26:52Z Could not load extension Flipper@connerdev

I tried removing each of those let lines - don't know this code or JS in general enough to know how to do anything more sophisticated. :(

It does look like an issue with this redeclaration vs. the new JS library in 3.4...

from cinnamon-spices-extensions.

Dice? We are talking about the Flipper and not Cube extension right?
So this
https://cinnamon-spices.linuxmint.com/extensions/view/36
and not this
https://cinnamon-spices.linuxmint.com/extensions/view/27

I installed Flipper right now.
I just needed to add cinnamon-version "3.4" to the metadata.json and it worked.
I don't get the error like you do.

from cinnamon-spices-extensions.

Hello, everybody.

I also tested it on Cinnamon 3.4 without problems. I didn't have the errors described by @mainmachine. Although, the "errors" were there. It seems that CJS works whenever it wants. LOL

I created a pull request that fixes those errors and other minor changes.

from cinnamon-spices-extensions.

Are you definitely running the newer libcjs?

libcjs0f                                    3.4.0-1~xenial0

...is what I'm running. This changed with the upgrade to 3.4.

@NikoKrause - Definitely Flipper. "No dice" is an American idiom meaning "no luck", sorry. :)

@Odyseus - tested your PR and it's now working for me too! Thanks. :)

from cinnamon-spices-extensions.

I had a similar problem (redeclaration of variable) with cinnamon-maximus. I made a pull request to fix it

from cinnamon-spices-extensions.

Fixed by #66

from cinnamon-spices-extensions.