libcvc: void functions in gvc-channel-map.c should not return values [-Wreturn-type] about cinnamon-desktop HOT 5 CLOSED

Reverting these back to g_return_if_fail fixes the build.

from cinnamon-desktop.

In your build remove -Werror flag and that should fix it. What platform are you building on

from cinnamon-desktop.

The platform doesn't matter, but I'm on FreeBSD. We use LLVM/Clang, which in recent versions has always been strict about stuff like this no matter the -Werror. This error is correct no matter how it is sliced, since void functions are not to return values (but can just return; ie exit) anyway and the glib macro reflects that.

from cinnamon-desktop.

Hi. Same issue on OpenMandriva with Clang 14. I can confirm that it compile with gcc without any problems.

from cinnamon-desktop.

I think in commit 6501be4 the author reverted the fix since it was already fixed beforehand in commit 206a909

from cinnamon-desktop.