Git Product home page Git Product logo

Comments (6)

spa-87 avatar spa-87 commented on May 30, 2024

Personally I would prefer to avoid this kind of feature. CloudFormation doesn't allow to have stacks with the same names in the scope of one region/account. Moreover, I would prefer to make CRD scope to Cluster by default in order to avoid confusion (it isn't critical though, it's a matter of the individual configuration and doesn't require changes at the operator code).
Currently matching is pretty obvious k8s stack == CFN stack. If we decide to implement the current feature, a single option is adding prefix/suffix by a namespace to a stack name. It will lead to backward-incompatible changes at stack names and problems with migration to the new version.
Thus if this feature is implemented once, it should be optional and disabled by default, IMHO.

from cloudformation-operator.

linki avatar linki commented on May 30, 2024

@spa-87 Thanks for sharing your opinion.

from cloudformation-operator.

mukaibot avatar mukaibot commented on May 30, 2024

My organisation is currently considering using Kubernetes Operators to manage Cloudformation stacks across a large number of accounts (well, ~150 accounts is a significant number where I am based).

I've just found your project @linki and I think this is awesome! Thank you so much for open sourcing this!

I think this feature would be required for us though, because for example we would want the same stack (probably with parameters) to be present in all our accounts, and from the description of this issue, the operator requires stack names to be unique. Would you consider a PR if we decide to use some of your code?

from cloudformation-operator.

linki avatar linki commented on May 30, 2024

Hi @mukaibot, thanks for your nice words. Please see my answer regarding the status of this project before starting to use it seriously: #20 (comment).

Also take a closer look at https://github.com/awslabs/aws-service-operator which takes a slightly different approach.

I would be happy to accept a PR implementing this but I would also consider @spa-87 concerns as well.

from cloudformation-operator.

linki avatar linki commented on May 30, 2024

One point in favour of a cluster-wide CRD and a 1:1 mapping from resource name to CF stack name is:

although how would outputs/refs work then, are they remapped somehow or just unsupported?

from cloudformation-operator.

cuppett avatar cuppett commented on May 30, 2024

Have added explicit .spec.stackName here:

cuppett/aws-cloudformation-operator@b410313

When not specified it'll tack on a crc32 hash of the Kubernetes UID to disambiguate.

Both those mechanisms lets the object names be re-used across namespaces. For existing stacks, requires the newer merges and objects first (where .status.statusId is captured so they can be found).

from cloudformation-operator.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.