Git Product home page Git Product logo

Comments (6)

jlyang1990 avatar jlyang1990 commented on July 28, 2024 2

Thanks @glemaitre for pointing it out. The primary goal of this FastTreeSHAP package is to develop a fast implementation of the TreeSHAP algorithm (feature_perturbation="tree_path_dependent") that reproduce the results from the original implementation of the TreeSHAP algorithm (feature_perturbation="tree_path_dependent") in the SHAP package. For those users who are currently implementing the TreeSHAP algorithm (feature_perturbation="tree_path_dependent") in SHAP package, we aim to provide them with a more efficient way of implementing it.

The potential issue you pointed out is relevant to the mathematical details of the TreeSHAP algorithm in the original paper, therefore we think it is more appropriate to discuss this issue with the original authors of TreeSHAP. If the original authors update the TreeSHAP algorithm (feature_perturbation="tree_path_dependent") in the SHAP package, we will update our implementations on our side to make sure they produce exactly the same results.

from fasttreeshap.

ogrisel avatar ogrisel commented on July 28, 2024

@glemaitre I think you meant "on correlated features".

from fasttreeshap.

glemaitre avatar glemaitre commented on July 28, 2024

Thanks, I corrected the title.

from fasttreeshap.

ogrisel avatar ogrisel commented on July 28, 2024

Actually: "TreeSHAP does not exact SHAP values" => "TreeSHAP does not compute exact SHAP values"

from fasttreeshap.

glemaitre avatar glemaitre commented on July 28, 2024

Just to give some feedback here. The issue with the tree_path_dependent approach has been discussed in the literature, e.g. Janzing et al.

The only way to not break the symmetry axiom is to perturb features in a marginal manner and not a conditional one. So I assume that there is nothing that can be done here.

from fasttreeshap.

jlyang1990 avatar jlyang1990 commented on July 28, 2024

Yes that's correct.

from fasttreeshap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.