Describe the bug Given a regular messages that has <code class="n

I'm guessing it's <div class="Box-header f

# is being replaced by%__lingui_octothorpe__% outside plural and selectordinal about js-lingui HOT 3 CLOSED

dan-dr commented on June 13, 2024

# is being replaced by%__lingui_octothorpe__% outside plural and selectordinal

from js-lingui.

Comments (3)

dan-dr commented on June 13, 2024

I'm guessing it's

js-lingui/packages/core/src/interpolate.ts

Line 84 in 133a6e9

if (token === "#") {

from js-lingui.

dan-dr commented on June 13, 2024

I narrowed it, the bug seems to occur only when the translation starts with # followed by variable.

EDIT: found more test cases that fail
It seems to happen whenever # is tokenized by itself (I think it only happens when it's next to a variable)

Here's a test case for i18n.test.ts:

it("._ should not bug when with #", () => {
    const messages = {
      Bad: "#{standing} in leaderboard",
      BadToo: "leaderboard standing is {standing}#",
      BadTooToo: "your id is {name}#{tag}",
      Good: "# standing in leaderboard",
      GoodToo: "standing is #{standing} in leaderboard",
      GoodTooToo: "leaderboard standing is #{standing}",
    }

    const i18n = setupI18n({
      locale: "en",
      messages: { en: messages },
    })
    expect(i18n._({ id: "Bad", values: { standing: 7 } })).toEqual(
      "#7 in leaderboard"
    )
    expect(i18n._({ id: "BadToo", values: { standing: 7 } })).toEqual(
      "leaderboard standing is 7#"
    )
    expect(
      i18n._({ id: "BadTooToo", values: { name: "hey", tag: "you" } })
    ).toEqual("your id is hey#you")
    expect(i18n._({ id: "Good", values: { standing: 7 } })).toEqual(
      "# standing in leaderboard"
    )
    expect(i18n._({ id: "GoodToo", values: { standing: 7 } })).toEqual(
      "standing is #7 in leaderboard"
    )
    expect(i18n._({ id: "GoodTooToo", values: { standing: 7 } })).toEqual(
      "leaderboard standing is #7"
    )
  })

from js-lingui.

thekip commented on June 13, 2024

it seems there is an issue in message format parser, it shouldn't treat '#' symbol as octothorpe outside { } expressions. Anyway, thanks for digging it and fixing.

from js-lingui.

Recommend Projects