Can't cross-compile "calc" example to i686-pc-windows-gnu about druid HOT 11 CLOSED

I believe this issue can be closed now, unless we want to keep it open for tracking the winapi-rs pull request.

from druid.

@vi, does it work for other examples? I have the same issue when I tried to use druid in my own project.

from druid.

Of course it doesn't. druid_win_shell doesn't compile, so nothing that relies on it can compile.

from druid.

@IslandUsurper , Does it work if you patch druid, adding that as i32?

from druid.

I'm sure it does, but I don't think that's the right solution. Instead, it looks like winapi needs to fix how it defines SetWindowLongPtrW (and friends) on x86 arch. Right now it aliases it to SetWindowLongW (etc), but that function takes a LONG instead of a LONG_PTR, which is what's going to be passed to it. And Rust doesn't consider isize and i32 to be the same type, even when they are the same size.

from druid.

I'm going to check this theory, and if it works, I'll file a PR against winapi and link it here.

from druid.

retep998/winapi-rs#735 is now a thing.

from druid.

@IslandUsurper Thanks for looking into this! It's not obvious to me whether this should be solved in winapi or at the next level above, but sounds like we have at the very least a plausible solution.

from druid.

This is still a problem. I ran into this while trying to cross-compile for i686-pc-windows-gnu.
Changing it to style as _ makes it work.
If I submit a pull request with that change, would it be acceptable?

from druid.

@crumblingstatue I would accept that PR.

from druid.

I think our solution is acceptable long-term.

from druid.