Git Product home page Git Product logo

Comments (5)

ericpignet avatar ericpignet commented on May 25, 2024

Good job!

My 2 cents:
I think a config profile would not be enough to really allow quick-swap of players, as all players would share the same score.ini files. Because of that, if I had several people playing in my household I would probably use multiple DTXMania installations. I think the main interest is when the same user has different configs depending on the song (for HH-x, FT-x, BD-x etc. options).
But if in the future we could also migrate the song.ini files (and possibly songs.db/songlist.db) into the SQLite DB, in order to also make scores per-user, then it makes perfect sense.
That would also make it easier to develop enhancements with stats/highscores/progress over time etc.

Regarding the code, I think that could have been better to keep ConfigIni.cs to be able to at least load the existing config, which would then be saved into the SQLite file, and possibly export it too (per user), to be able to move easily between the different DTXMania versions.

from dtxmanianx.

limyz avatar limyz commented on May 25, 2024

This is a fork from issue #23, will keep this open for continuity.

from dtxmanianx.

fisyher avatar fisyher commented on May 25, 2024

But if in the future we could also migrate the song.ini files (and possibly songs.db/songlist.db) into the SQLite DB, in order to also make scores per-user, then it makes perfect sense.

I didn't mentioned it in the first post, but I do intend to migrate score.ini files and songs.db into SQLite DB as well. This is but just a starting point to eventually have a Scores per user feature.

While I agree that a feature to import config from an external file into SQlite DB may be useful, I do not think keeping Configini.cs helps at all. It is a hot mess, parsing and writing ini file manually line by line. Also, all data members are copied over to ConfigDB.cs anyway so there is no loss of important information. A separate new implementation would be much cleaner.

from dtxmanianx.

ericpignet avatar ericpignet commented on May 25, 2024

Well as soon as you keep the hot mess for import only, I don't think it matters too much. That would just save you the efforts of writing the parsing code again just for import.

By the way, I believe there are quite a few technical options in config.ini which are not configurable in the UI. Are you planning to implement them in the UI? If you don't plan to, the import function is quite important as it's the only way to apply these options to your config.

from dtxmanianx.

fisyher avatar fisyher commented on May 25, 2024

Yes, I am aware that some of the options are not configurable in-game. I do plan to add some of them in the UI; need to review which ones make sense to be configurable in UI.

from dtxmanianx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.