Git Product home page Git Product logo

Comments (6)

mintsuki avatar mintsuki commented on September 26, 2024

Thanks for reporting the issue. This is indeed a problem, but one that plagues C codebases all throughout, not just the Limine project...

I have changed the include guard macro in limine.h as that is the most important one since it's the exposed header, and changed Flanterm to also not use reserved identifiers for its include guard macros. I also used -isystem instead of -I for the freestanding-headers includes (as it should be since they are libc-replacement headers).

Other than that, it hardly matters since the reserved identifiers used are unlikely to cause conflicts, but if there are any issues at any point stemming from reserved identifier conflicts I'll fix those on a case-by-case basis.

from limine.

elfring avatar elfring commented on September 26, 2024

Thanks for your adjustment of an affected include guard.

๐Ÿ’ญ How do you think about to avoid any more that this software depends on undefined behaviour?

from limine.

mintsuki avatar mintsuki commented on September 26, 2024

I am not quite sure what you mean, but beyond the use of reserved identifiers in some places, if there are other instances of invoked undefined behaviour, please let me know.

from limine.

elfring avatar elfring commented on September 26, 2024

๐Ÿ’ญ Would you become interested to use a development tool like โ€œclang-tidyโ€ for corresponding source code adjustments?

from limine.

mintsuki avatar mintsuki commented on September 26, 2024

That's not what I asked. I will also stop replying to you as well, given it is likely either some bot or AI talking, not a real human.

from limine.

elfring avatar elfring commented on September 26, 2024

That's not what I asked.

๐Ÿ‘€ We know that some update candidates are still remaining.

I will also stop replying to you as well, given it is likely either some bot or AI talking, not a real human.

Please reconsider such a view.
๐Ÿ”ฎ Can I convince you anyhow about further improvement possibilities?

from limine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.