Comments (6)
Thanks for reporting the issue. This is indeed a problem, but one that plagues C codebases all throughout, not just the Limine project...
I have changed the include guard macro in limine.h
as that is the most important one since it's the exposed header, and changed Flanterm to also not use reserved identifiers for its include guard macros. I also used -isystem
instead of -I
for the freestanding-headers
includes (as it should be since they are libc-replacement headers).
Other than that, it hardly matters since the reserved identifiers used are unlikely to cause conflicts, but if there are any issues at any point stemming from reserved identifier conflicts I'll fix those on a case-by-case basis.
from limine.
Thanks for your adjustment of an affected include guard.
๐ญ How do you think about to avoid any more that this software depends on undefined behaviour?
from limine.
I am not quite sure what you mean, but beyond the use of reserved identifiers in some places, if there are other instances of invoked undefined behaviour, please let me know.
from limine.
๐ญ Would you become interested to use a development tool like โclang-tidyโ for corresponding source code adjustments?
from limine.
That's not what I asked. I will also stop replying to you as well, given it is likely either some bot or AI talking, not a real human.
from limine.
That's not what I asked.
๐ We know that some update candidates are still remaining.
I will also stop replying to you as well, given it is likely either some bot or AI talking, not a real human.
Please reconsider such a view.
๐ฎ Can I convince you anyhow about further improvement possibilities?
from limine.
Related Issues (20)
- No background highlighting when using UEFI serial console
- Serial console speed setting missing (or auto discovery) HOT 1
- feature request: limine boot protocol uefi system table request HOT 2
- Onboard to nixpkgs HOT 20
- Feature Request: Implement grub-style MAC-based PXEBoot limine.cfg configurations. HOT 2
- Migrating to QOI? HOT 2
- Support basic theme configuration HOT 1
- Limine Memory map feature results zero entries. HOT 3
- Bug: Limine does not support being loaded above 4GiB HOT 5
- Make limine compatible with the boot loader specification by supporting an XBOOTLDR partition HOT 10
- Config file not found HOT 10
- Cannot boot if i install limine on another disk HOT 1
- Implement loopback for booting disk image files HOT 4
- Lack of checking of the fat32_bpb.bytes_per_sector
- Lack of checking of the fat32_bpb.sectors_per_cluster
- Install limine on disk without limine installer HOT 2
- Missing files in release assets HOT 1
- Binaries within the repository HOT 1
- Potentially broken EFI memory map HOT 15
- Black screen if not using TEXTMODE HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from limine.