Comments (5)
ThumbnailFilterLoader
initializes filter class inside the load
method (without dependency injection) which prevents mocking. Any hints how to properly unit test filter loaders?
from liipimaginebundle.
we could define a protected getter and then in the tests overload that method for mocking
from liipimaginebundle.
@MHeleniak: are you still motivated to work on adding tests? if so let me know if my response was clear enough.
from liipimaginebundle.
It was clear. Thanks. To be honest I asked because I have several custom filter loaders which needed to be unit-tested.
I will try to contribute unit tests for ThumbnailFilterLoader
in the coming days.
from liipimaginebundle.
ah ok thx. if you think the filters are also relevant to others, feels free to contribute them as well.
from liipimaginebundle.
Related Issues (20)
- How to correct set cachePrefix for S3 resolver?
- Image not generating but the image link includes a resolve path. HOT 2
- Drop support for unsupported dependencies in v3 HOT 2
- Separate OneupFlysystem and league/flysystem-bundle in the docs HOT 4
- Provide a simple demo repo HOT 1
- Add Provider Data/Path to 404 when creating images HOT 1
- Use s3 for cached images too HOT 3
- Redirect not working when resolving the first time HOT 5
- Document integration with backblaze adapter HOT 1
- help,how to override filter use programmatically HOT 2
- installation failure HOT 4
- $imagineCacheManager->resolve($image, $filter) doesn't generate file in controller HOT 9
- Bundle impossible to install or update HOT 3
- exif data not persisted in image HOT 1
- 2.12.2 autowiring of Imagine\Image\ImagineInterface broken HOT 2
- Regex in redirect optimization doc matches more than expected HOT 5
- Images are automatically rotated HOT 5
- bad yaml in documentation
- Resolve returning /cache even after :remove HOT 1
- leverage flysystem for all filesystems
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from liipimaginebundle.