Comments (3)
I can confirm that your code fixes the problem.
Thanks, your addon is really great!
from godot-xterm.
Hi @ConteZero, thanks for reporting this. I can reproduce the issue in this scene:
It also occurs with KEY_LEFT and KEY_RIGHT when there are inputs on the left and right.
Can you try with this code instead and let me know if it fixes the problem:
func _gui_input(event):
_native_terminal._gui_input(event)
if event is InputEventKey and event.pressed:
# Return to bottom of scrollback buffer if we scrolled up. Ignore modifier
# keys pressed in isolation or if Ctrl+Shift modifier keys are pressed.
if (
not event.scancode in [KEY_ALT, KEY_SHIFT, KEY_CONTROL, KEY_META, KEY_MASK_CMD]
and not (event.control and event.shift)
):
_native_terminal.sb_reset()
if event.scancode in [KEY_LEFT, KEY_UP, KEY_RIGHT, KEY_DOWN, KEY_TAB]:
accept_event()
_handle_mouse_wheel(event)
_handle_selection(event)
from godot-xterm.
I also encountered another problem, but I don't know if it can be related to this one.
With the same setup (scene with Terminal,Pty and other input nodes) if I execute a command with sudo
the terminal screen do not show the command output, to force a refresh I need to press a key or click on other input field to switch focus.
The same command executed without sudo
works as expected, the screen show the output.
ping www.google.com
works
sudo ping www.google.com
doesn't work
from godot-xterm.
Related Issues (20)
- Change the default theme
- Make better use of space for wide characters
- PTY output not shown without GUI activity HOT 6
- "Unicode error: no space left" cause strange behaviors HOT 4
- Incorrect intial PTY size when used with Terminal
- Characters disappear after resizing window when using a custom theme
- Characters disappear when changing theme
- Godot 4 HOT 3
- [Godot 4] Make `update_mode` property an enum drop-down in editor inspector HOT 1
- [Godot 4] Fix terminal editor tabs
- [Godot 4] Menu scene title not displayed correctly HOT 1
- [Godot 4] Use EditorSettings to configure editor terminal
- [Godot 4] Fix editor terminal shortcuts
- [Godot 4] Fix tests HOT 1
- [Godot 4] Fix CI/CD HOT 2
- [Godot 4] Highlight editor terminal border on focus HOT 1
- vim plugin
- Use as code editor - replace Script
- Godot 4 functionality. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from godot-xterm.