Git Product home page Git Product logo

Comments (5)

rodentrabies avatar rodentrabies commented on August 25, 2024 3

For now, an easy way to bypass this until there's a more general solution, is to add -Wno-implicit-fallthrough to cflags field in target-defaults in apps/desktop/node_modules/grpc/binding.gyp file, which is pulled in with npm run setup.

Update: see grpc/grpc#12536 for more details.

from lightning-app.

Thann avatar Thann commented on August 25, 2024 1

Even the latest release of grpc (1.6.6) uses an ancient version of boringssl that's over a thousand commits behind. Naïvely updating to the latest version has even worse errors =[

from lightning-app.

rodentrabies avatar rodentrabies commented on August 25, 2024

It seems that the problem is in grpc v1.1.1, which depends on an older boringssl version, which doesn't have marks for switch-statement fallthrough behaviour. It could be fixed on the grpc side by updating git submodule for boringssl.

from lightning-app.

bryanvu avatar bryanvu commented on August 25, 2024

Thanks @mrwhythat. I'll play around with this a bit. Building boringssl on Windows was a huge pain as well, and if this works, that would be a big plus.

from lightning-app.

mo3rfan avatar mo3rfan commented on August 25, 2024

This would most likely get fixed if the following is done:

1. https://boringssl.googlesource.com/boringssl/+/60931e2d8afff685f5460cf9a88469b96942849b (merged)
2. Submodule update PR (that contains above fix): grpc/grpc#12922 (PR contributor seems to have bit of an issue here I think)
3. Bump grpc npm package to get the fixes.

from lightning-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.