Comments (4)
After that comment, in working further on things, I think a reasonable approach would be to replace HandleError in Channel returns (and some places in ChannelManager) with some Channel-specific return value which just says "SendErrorMessage" and then have ChannelManager handle_error! map it to DisconnectPeer or SendErrorMessage based on whether this will close the last of our channels with that peer or if we have some other channel with them just SendErrorMessage.
from rust-lightning.
Specifically, the comment at #151 (comment).
from rust-lightning.
What is the consistent behaviour that isa desired here for DOS like behaviour from nodes?
I saw in #151 that it talks about the error action none, but MsgHandleErrInternal::send_err_msg_no_close is filling in the action with a some<>
from rust-lightning.
This would give us an opportunity to clean up the stupidly long error-return lines by deduplicating the err string and not having so many optitons to pick from.
from rust-lightning.
Related Issues (20)
- Consider removing `path_id` from `Responder`
- Upgrade `bitcoin` to `0.32` HOT 1
- Expose `advance_path_by_one` HOT 6
- The link to Sensei in the README is broken
- force close is not always broadcasting latest TX HOT 3
- Propagate routing errors up to `send_payment_for_bolt12_invoice` HOT 8
- Put musig2 dependency behind a feature? HOT 4
- #3024 exposes dummy tx in `DiscardFunding`
- Dont abandon payments based on the `payment_id` in an unauthenticated `InvoiceError` message (or any other unauthenticated msg) HOT 3
- Dont fail with `PaymentFailureReason::UserAbandoned` when failing in response to an OM
- Support new experiemntal ranges for offer tlvs HOT 1
- #2989 Followups
- Abort sending early in BOLT12 `pay_for_offer` if we have insufficient funds
- Upgrade bech32 dependency HOT 1
- Onion Message `Responder` creates a circular reference
- Blinded Path Selection May Use Tor-Only as Intro Node HOT 3
- Document persistence failure behavior for all events
- `OnionMessenger` needs a `Notifier`
- #2995 Followups
- Cleanup Bech32 logic, isolate or make away with bech32 dependency HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-lightning.