Comments (2)
After integration with
lightning-liquidity
, I believe the user will want a simple LSPS client to check the integration is well. The clients are public, but they can not really in used by any user because they are sealed.For example, we have a public struct
LSPS2ClientHandler
, but the fields inside the struct are private and the new function is private (only public in the crate). That is, theEventQueue
is private but it is required byLSPS2ClientHandler
.
Yes, constructors are (currently) intentionally hidden as LDK-based implementations will always need the CustomMessageHandler
implemented by LiquidityManager
, which currently is the main object of this library. The user might then access the sub-protocol handlers, e.g., via the the lsps2_client_handler
accessor.
Note that we're still in the middle of further modularizing and improving the API (cf. #69), and that the main reason for the message handler objects being individually exposed is that we intend to make them reusable even by non-LDK implementations, which is however not supported as of now.
from lightning-liquidity.
Closing this as resolved, even though we might want to improve the API in the future.
from lightning-liquidity.
Related Issues (20)
- LSPS2: Prepayment probing breaks flow HOT 2
- LSPS 0/1/2: Ensure all sat/msat fields are de/serialized from/to "string" HOT 1
- Eventually drop peers from the ignore list
- LSPS2: Improve `invoice_parameters_generated` docs
- LSPS1: Account for semantics change of `confirms_within_blocks`
- LSPS1: Remove `website` field
- LSPS2: Emit event when fee has been collected for a channel HOT 1
- LSPS1: Mirror all fields in `CreateOrder` response HOT 1
- LSPS2: Fail intercepted htlcs if lsp open channel fails for whatever reason
- LSPS2: Allow LSP to re-use existing channel if it has capacity without skimming fee
- `enqueue` is a mutable behavior but with a immutable function type HOT 3
- Adjust LSPS1 field/method names
- Make service advertisement configurable
- LSPS1: Disallow compiler warnings once implementation is finished
- LSPS1: Rename `id` field to `user_channel_id` HOT 1
- LSPS2: Expose client-side event(s) for the buy request failure case
- LSPS1: Fix API to maintain consistency with protocol
- LSPS1: Allow null for `minimum_onchain_payment_confirmations`
- Implement `invalid-parameters-error` in LSPS1 / LSPS2
- LSPS1: Simplify channel struct
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightning-liquidity.