Comments (4)
@ethib137 There are issues with negative margin, but I think we need to have a discussion with @drakonux, @emiliano-cicero and @marcoscv-work about how the vertical nav should be positioned in mobile especially with other items like a search input. In the current state, it's supposed to be another navigation like bar in mobile.
from clay.
@ethib137 We were assuming a vertical nav would always be inside a grid column which has 12px gutters. Do we need both? Negative margins when inside a grid column and no margins when not?
from clay.
@emiliano-cicero , has this already been discussed how this should look on small screens / mobile?
from clay.
I don't think it was discussed directly but we probably assumed having a default margin given by the container. The example for the vertical-nav on mobile has no-margin because it's aligned to the form and as @pat270 says, I think it's probably the 12px gutter (although visually it seems more like 16px so there might be something else).
If it's placed without a container then it should respect the margins from both sides.
Regarding the position, I don't know if I understood correctly but I'll try to answer: the vertical nav should be considered almost as part of the content since the interaction is directly connected with the content on the left/bottom, the search bar would go on top as is part of the management toolbar (with its mobile version).
from clay.
Related Issues (20)
- ClayMultiSelect doesn't register an 'onChange' event when it is inside of a form HOT 6
- DropDown with group and no items breaks component HOT 1
- Modal doesn't allow for dynamically growing height. HOT 3
- Possibility of specify different aria-label for Cards HOT 1
- Empty state reduced-motion is not working correctly HOT 6
- Picker menu is not visible when open
- Vertical nav and pagination border to be a straight shape HOT 1
- `onChange` callback doesn't fire for "uncontrolled" components HOT 1
- New design for the year select inside the date picker HOT 1
- @clayui/css: Variables _icons.scss shouldn't fail if $nav-link-padding-y is unavailable HOT 1
- Vertical Navigation Dance HOT 1
- MultiSelect is not doing autocomplete filter
- @clayui/css: Add utilities for globally set/disable text underline, letter spacing, truncating, focus borders HOT 4
- TreeViewItem is not being read correctly with the screen reader HOT 2
- New AI icon for Echo HOT 1
- New Accessibility Icon HOT 1
- @clayui/css: Cadmin btn-sm icons should be 16px x 16px HOT 1
- Passing a `children` function to MultiSelect behaves oddly HOT 9
- MultiSelect: provide backward compatibility for `menuRenderer` HOT 1
- Autocomplete menu added to `dropdown-menu-indicator-start` class unnecessarily HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clay.