Comments (10)
Makes sense. UX has specifically asked that only designed svg icons are shipped by default, so we are also going in this direction.
We just need to make sure we have a clear path for developers to add icon fonts and use them independently of what we ship in clay.
from clay.
If themes could depend on bundles then we could have FA3 and FA4 resource providers.
@jbalsas Can the new loader help on this? Are static packages’ resources available?
from clay.
Yeah, I think all resources are available when bundled using the new method. In any case, it sounds like these could go as ThemeContributors, for example.
from clay.
Just for clarification, we want to stop bundling the icon fonts in Clay, but we'll still figure out a way to provide them in Liferay Portal ootb.
from clay.
[…] these could go as ThemeContributors […]
Well, usually I think it’s a theme’s responsibility to bring the icon packs to the page but actually it’s more an editorial requiriment.
So from one side apps and themes should be able to “ask” for an icon pack, but also editors need to access them. Totally Out Of Topic™ but having a DDM field type “Icon” where you can choose one from the available icon packs would be totally awesome.
from clay.
ThemeContributors (albeit their bad name) add resources globally independently of the applied Theme. That's why it might be a good option to make them easily available. They double as themelets, so a themelet including FA4 could make it be always available if deployed as a ThemeContributor.
Out of Topic™, where and how would you use the Icon field? Is this something that should be needed inside the WYSWYG editors as well?
from clay.
Out of Topic™, for example if you are writing a list of features of a product (see this example from smc.it). Sometimes you have them as rasterized images, sometimes as SVG, sometimes as icons in the icon packs have in the page (typically font-awesome). Another very good case are Call to Actions and buttons (see later in that same page), where icons must be either icon fonts or vectorial.
from clay.
The perfect solution would be an icon chooser, configurable to accept (or not) files from the DM and/or icon fonts and/or SVG icons.
from clay.
Other examples where such a selector would have benefitted: click on a slice here (it’s a Web Content structure/tmpl), or look at «Servizi Online» in this page, or as AssetCategoryProperty values here.
from clay.
/cc @aaragueslr, @JorgeFerrer, @marcellustavares
from clay.
Related Issues (20)
- TreeView: Actions do not open by Enter key with JAWS HOT 2
- @clayui/css: Cadmin VerticalBar resizer is too narrow HOT 1
- @clayui/css: Cadmin focus-visible Clay Range doesn't show outline on tab HOT 2
- @clayui/empty-state: Append _reduced_motion to the imgSrc url by default HOT 6
- @clayui/css Cadmin modal doesn't have overflow-y: auto HOT 2
- @clayui/modal Enable modal-dialog-scrollable HOT 11
- JSP Sample Code Not Correct
- @clayui/drop-down ClayUIDropdownWithItems: RadioGroup with radio Items not getting checked HOT 1
- xlinkHref icons display error when using CDN HOT 1
- Additional notes in the getting started section HOT 2
- Add Flag of Canada HOT 1
- Can we rename ClayDatepicker property `timezone` to `timeZone`? HOT 1
- Migrating to Clay Picker HOT 1
- Unable to select pages from the ellipsis dropdown in Clay Pagination HOT 2
- Onclick not happening on Pagination ellispsis drop-down HOT 2
- Clay Navigation Bar position not correct HOT 1
- ClayTooltipProvider isn't working HOT 1
- Error with React version 18 HOT 1
- When Modal opens the focus goes to the title HOT 3
- Copy-pasting into MultiSelect HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clay.