Git Product home page Git Product logo

Comments (3)

lifaon74 avatar lifaon74 commented on August 26, 2024 1

As specified in the README, the polyfill is not 100% accurate. A full implementation will be several hundred of kilobytes...
You could simply test if url === new URL(url).href

from url-polyfill.

KovDimaY avatar KovDimaY commented on August 26, 2024

Well, true...
Thank you for the advice! :D

from url-polyfill.

KovDimaY avatar KovDimaY commented on August 26, 2024

As a small comment about the url === new URL(url).href solution.

It does not work in general case, because URL(url).hrefalways come with a "/" in the end. That means that if the user provides https://www.google.com as a url, the URL(url).href = https://www.google.com/ and the condition becomes to be false.

I used Math.abs(url.length - URL(url).href.length) < 2 as a condition and it worked for all the cases I needed to cover. Maybe it will help you too.

PS: If you know a better solution or you see a flow in my current one, let me know, please. Thank you in advance! :D

from url-polyfill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.