pkcs_1_pss_decode.c about libtomcrypt HOT 3 CLOSED

Hi,

you're right, salt is allocated and never used, but that's not the problem.

Removing the verification that PS starts with 0x0 is absolutely no option.

Looking at the calling code and the TLS RFC I suspect that the salt length is wrong.

Here's a potential patch 0001-Fix-length-of-the-salt.patch.txt which could probably solve the issue, but I couldn't get tlssimple.c to connect to something since the certificates fail to load or I don't know what, so I couldn't test it. (Looks like I'm hitting eduardsui/tlse#88 as well).

Please get this sorted out with @eduardsui

from libtomcrypt.

Hey,

I fixed these lines now. It doesn't fail anymore in the check for DB == 0x00, but it fails here:

if (XMEMCMP(mask, hash, hLen) == 0) { *res = 1; }

i am not sure if this is a problem of the TLS code or of the pkcs_1_pss_decode method. I would be very happy if you could help me here again. @eduardsui is not answering since months.

from libtomcrypt.

I found the solution btw. Thank you anyways. If you are interested for the solution, look at
eduardsui/tlse#89
There is my comment for that issue.

from libtomcrypt.