Include random str in responses when listing submissions about ngshare HOT 11 CLOSED

They are generated using:
random_str = base64.urlsafe_b64encode(os.urandom(9)).decode('ascii')

from ngshare.

@aalmanza1998 can you remind me of how random strings look like?

from ngshare.

Is the random string really necessary in ngshare? It seems like it's only used to prevent unauthorized access to submissions. ngshare should be able to do that without a random string.

from ngshare.

We may want to prevent the case that a student submits two requests at the same time and accidentally generates two submissions with the same timestamp (Though it is very likely, I think there is no guarantee that the timestamps will be always different). So adding a random string can decrease this possibility of collision further.

from ngshare.

The timestamp has microsecond precision, so it's extremely unlikely that there will be duplicate timestamps. If we are really so concerned about such a rare event, we should generate a unique submission ID for each submission and use that instead of a random number.

from ngshare.

What would that ID consist of?

from ngshare.

uuid is a good choice

from ngshare.

From python help:

# make a random UUID
>>> uuid.uuid4()    # doctest: +SKIP
UUID('16fd2706-8baf-433b-82eb-8c7fada847da')

It seems to be almost collision-free. e.g. https://softwareengineering.stackexchange.com/a/130298

I think you can first continue working with the current random string. Changing this should be easy in backend and require no work in frontend.

from ngshare.

@Lawrence37 are you having issues with notebook_hash or make_unique_key or are you just looking at alternatives?

from ngshare.

Part of it is that retrieved submissions don't store the random string, and consequently, releasing feedback lacks the required random string. It would be great if we don't introduce a way to store the string in the filesystem so that we can maintain maximum compatibility with the current exchange.

The other reason is to avoid unnecessary clutter in the API.

from ngshare.

I kind of understand. Can you demonstrate it more tomorrow during / after the meeting? If reasonable I think we can remove random str from API.

from ngshare.