batman-adv-auto-gw-mode sets non-existing batman-adv uci setting about lime-packages HOT 5 OPEN

Quoting OpenWrt's wiki:

Configuration for batman-adv from 2019.1 and onward is done in /etc/config/network (only). There is no /etc/config/batman-adv file used with current versions.

https://openwrt.org/docs/guide-user/network/wifi/mesh/batman#general

So this is broken since some time, as OpenWrt 19.07 used batman-adv 2019.2
https://github.com/openwrt/routing/blob/openwrt-19.07/batman-adv/Makefile#L12

But it was working on OpenWrt 18.06 as it used batman-adv 2018.1
https://github.com/openwrt/routing/blob/openwrt-18.06/batman-adv/Makefile#L12

from lime-packages.

From here it seems easy to fix just setting the same option in /etc/config/network under the bat0 interface:

config interface 'bat0'
	option proto 'batadv'
	[...]
	option gw_mode 'off'

https://openwrt.org/docs/guide-user/network/wifi/mesh/batman#associate_batman-adv_with_mesh

Some other interesting info can be located in the documentation of gw_mode:

Gateway mode, if set to server other nodes are notified of that node's internet connection and must be complemented by gw_bandwidth, that notifies the algorithm that server is one of the best paths for internet access.
If set to client, the criteria by which batman-adv will choose a gateway(other nodes with gw_mode set as server) is required to be set with gw_sel_class.

https://openwrt.org/docs/guide-user/network/wifi/mesh/batman#batman-adv_options_for_bat0_the_main_mesh_interface

So it is possible that it will not work without gw_bandwidth and gw_sel_class.

from lime-packages.

Also, and this was broken also in LibreMesh 2020.1, this line

has to point to network.bat0.gw_mode='client' (at least on OpenWrt 19.07, I did not try on other versions).

from lime-packages.

And this file is not there anymore, still have to check where it went:

from lime-packages.

And this file is not there anymore, still have to check where it went:

lime-packages/packages/batman-adv-auto-gw-mode/files/etc/watchping/wan-ok.d/batman-gw

Line 5 in 06399e5

if grep -q "^=>" /sys/kernel/debug/batman_adv/bat0/gateways ; then

Surprise: it is not there because this package does not select-depend on CONFIG_BATMAN_ADV_DEBUGFS, so it has never been there and the /etc/hotplug.d/net/99-batman-gw in:

has never been executed.

I was looking a bit on the rest of the code and a new interface gets generated here
https://github.com/libremesh/lime-packages/blob/master/packages/batman-adv-auto-gw-mode/files/etc/uci-defaults/91_batman-adv-auto-gw-mode

with DHCP (so it starts looking for an IP). And stops offering for an IP. But stops offering on the br-lan interface, not on the Anygw's lm_net_br_lan_anygw_if where dnsmasq is running nowadays.

Basically this is an outdated package and unless anyone is willing to adopt it I would propose to eliminate it (or move to an archive directory in this same repository) in favor of the more recent babeld-auto-gw-mode
https://github.com/libremesh/lime-packages/tree/06399e5de7fb7b9d3cf13c19f7bf70accb11299a/packages/babeld-auto-gw-mode

Opinions @spiccinini @selankon @G10h4ck @altergui ?

from lime-packages.