view-schedule.php hide label -> privacy config (GDPR) not working from v2.8.2 again about app HOT 6 OPEN

Nice, glad it's working for you, I've also implemented it in our installs and seems to be working ok.

I've noticed that the comments were stripped, but I never went to look why was that, oh well now my ocd won't let me stop looking at the file. I don't know how long it will take to get to that issue, there's alot of things needing attention before, but everytime that I open that file it will remind me of it.

from app.

Thanks for the report, especially for finding were the issue started to occur. I'm going to look into this as soon as I can.
If you detect(ed) similar issues let us know, everything that has to do with GDPR in europe is a big deal.

from app.

That sounds very good.

I reviewed some docs, so the key point should be this setting, that is not working (the others i mentioned above should work fine):
$conf['settings']['privacy']['view.reservations'] = 'false';

Public Schedule Visibility
By default only logged in users can view schedules, but this can be changed with some configuration updates.

In Application Configuration the privacy section contains two settings – view.schedules and view.reservations.

view.schedules will allow unauthenticated users to browse your schedules, though they will need to log in to book any resources. A new menu option on the login page will be displayed to let users open the schedule in a read only mode.

view.reservations lets you control whether or not unauthenticated users will be able to see reservation details from the read only schedule. By default, only available and unavailable times are shown. Setting this to true will show full reservation details to unauthenticated users.

May it helps you

from app.

yes, every little bit of info is helpfull, I will get around this issue over at the weekend (I hope)

from app.

I just added a fix to the develop branch, that should take care of this issue, if can test it and report back it would be great, just replace the lib/Application/Schedule/SlotLabelFactory.php with the one on the develop branch and you should be good to go.

By the way while investigating this issue I've noticed that sometimes a label saying "Private" replaces the private data, but in certain situations the label is simply blank and while this is not a showstopper issue it's annoying. The issue is on the exact same place that the fix was added, so in a nearby future I hope to take a closer look at that file/function and make it neater.

from app.

Hi, as far as I could test at the moment with my config...it looks fine.
The SlotLabelFactory class is also used for Web/monitor-display.php, so the bug is fixed there too...great.

Thanks a lot for your quick support

PS (off-topic): A little annoying is, that the config.php will be cleared from all comments during config-update while System-Upgrade and new config-entries are not just added at the end.

from app.