Git Product home page Git Product logo

Comments (10)

effgarces avatar effgarces commented on July 18, 2024 1

I have yet to test booked with php 8, I believe that I've tested up to 7.4, I need read what changes php8 brings to the table and test booked with it an see what will be needed to bring it up to speed. I will keep this in mind when the time comes for a new maintenance release and while I don't know if will be able to provide php8 compatibility I can at least update the readme to let people know what versions booked currently works on.

from app.

simonflood avatar simonflood commented on July 18, 2024

FYI development-guide.txt references yet another version of PHP, 5.3.

It's early days but I can confirm BookedScheduler 2.8.5.3 appears to work with PHP 7.4.

from app.

effgarces avatar effgarces commented on July 18, 2024

I believe that the development-guide.txt wasn't updated in quite awhile, probably even before support for php 7 was added.
In the mean time I tested version 7.4 and seems to be working well, I'm hoping that in the coming weeks I will have some time to test version 8 and see what issues come up.

By the way thanks for the commits, I'm going over them right now, and will be merging soon after.

from app.

bpinsard avatar bpinsard commented on July 18, 2024

Found some bugs related to version 7.4

Deprecated: implode(): Passing glue string after array is deprecated. Swap the parameters in /var/www/booked/tpl_c/32065a7ae396234f77db2db15fe2c07ff3423ef4_0.file.attribute-list.tpl.php on line 103

seems that code is 5.x or maybe the template extension need updating?

from app.

treborin avatar treborin commented on July 18, 2024

@bpinsard, flush your tpl_c dir

from app.

bpinsard avatar bpinsard commented on July 18, 2024

@treborin I did flushed it multiple times, without success.

from app.

bpinsard avatar bpinsard commented on July 18, 2024

related to smarty-php/smarty#559
Tried updating Smarty, but doesn't solve the issue.

from app.

effgarces avatar effgarces commented on July 18, 2024

Thanks for researching this issue, it seems that we will need to add a modifier to smarty to allow this to work correctly. I went ahead and added the file, seems to work ok, but further testing is needed, check commit 012f01d
Just add the file to your install, flush the tpl_c folder and go to the attributes list.

from app.

alexizher avatar alexizher commented on July 18, 2024

Have you thought about adding the file upload option to the list of custom attributes?

How can I make the reservation title field a drop down list?

from app.

effgarces avatar effgarces commented on July 18, 2024

No, never even crossed my mind adding a file upload option to the custom attributes. There's already an attachment functionality for the reservation, so adding it also to the custom attributes wasn't something that I had thought on doing, there's probably some cases were something like that will be useful but right now I think there are more important things to work on, unless of course someone is willing to contribute that feature.

As far as I know there isn't an official way for making the title a drop-down list, so if you need that you will need to modify your install. I have to say I'm not seeing a usage case for that .

I would ask that in the future you create a new issue or ask on gitter about these and other matters, in order to avoid discussing matters that do not relate directly to the current issue.

from app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.