Escape problem in tpl/Reservation/pdf.tpl about app HOT 6 CLOSED

That is weird, I swear I tested it and it was working, must have missed something, I will check it as soon as I can.

from app.

I just added the fix to the bugfix branch, thanks for the information.

from app.

Hello again, i'm really sorry but turns out my fix was worst than the original error, i must have messed up with copy/paste because yesterday i thought i had something working...

Anyway, i don't know how to use correctly the |escape('javascript'), so i just replaced single with doubles quotes.
[{ content: "{translate key='RepeatUntilPrompt'}", styles: { fontStyle: 'bold'}},

from app.

These things happen, I've fixed the issue with the escape ([{ content: '{translate key=RepeatUntilPrompt|escape:'javascript'}', styles: { fontStyle: 'bold'}},) and after checking the rest of the file I've added this fix to two more places, so thank you for letting me know and following up.

from app.

Hello,
The fix in 2.8.5.3 doesn't seems to work. With french label "Jusqu'au", it still make recurrent reservation impossible to edit because of "SyntaxError"
Looks like the escape filter is not applied correctly, so i still had to quote it with double quotes instead of single to make it work...

from app.

I just pushed a final (I hope) fix. The previous the "fix" as missing a couple of brackets, I think that while testing I must have forgotten to clear the cache and missed that it wasn't working.
I've tested it and seems to working properly now, I also updated the latest maintenance release with the correction.

from app.