Build with v0.6.14 fails on OS X about node-gitteh HOT 6 CLOSED

Builds fine with node v0.8.11.

from node-gitteh.

Yeah, the EIO library was updated in Node 0.8,
and his API has substantially changed, breaking backwards compatibility.

That happened also on other addons, see my comments at benmills/robotskirt#10.
Now, LibUV has its own event functions so there's no need to use EIO at all.

from node-gitteh.

Not sure how realistic it is to exclude < 0.8 but configuration in package.json to fail the build on older versions would probably be acceptable.

from node-gitteh.

I'm not saying to exclude 0.6,
I'm saying the API changed between 0.6 and 0.7,
and its diffucult to come up with a fix that works in both 0.6 and 0.8,
because EIO is not versioned.

2012/10/2 Brian Lalor [email protected]

Not sure how realistic it is to exclude < 0.8 but configuration in package.json to fail the build on older versions would probably be acceptable.

—
Reply to this email directly or view it on GitHub.

from node-gitteh.

I'm picking gitteh back up with the goal of completing the interfaces to the libgit2 functionality still missing in the latest release, but to keep things more straightforward I'm only going to be targeting 0.8. Depending on the demand I may look at 0.6 compatibility, but given that 0.10 won't be too far away and eio is deprecated in Node.js codebase it may not happen.

from node-gitteh.

@blalor With 0.8 and 0.10 stable floating about nowadays I really don't see 0.6 compatibility being a very high priority at this point. If you wanted to take it up personally then definitely get in touch though!

from node-gitteh.