Bug: Index.Unstage() about libgit2sharp HOT 8 CLOSED

Hello,

thanks for this report. However, I'm not sure I follow you.

I think this is not what you want.

Could you be a bit more descriptive about the issue you're encountering? A failing test would be even better :)

from libgit2sharp.

Hi again ;-)

I have currently no code or tests available, so I will try to explain again.
(Maybe I can post some code tomorrow)

What I did:

1. Added a new file to git Git index using Index.Stage()
2. Commit
3. Tried to remove the file added in 1. from the git index using Index.Unstage() (not sure if this is the right way)
4. Commit

The result: The second commit did not contain any changes, the file was still indexed.

I looked into the code and detected a Unstage --> Restore... --> AddToIndex() loop.
Without the ResotrePotentialPreviousVersionOf() method it works for me.

from libgit2sharp.

Ok. I got it, now :)

I'm working on something and will let you know about the results.

from libgit2sharp.

Formally you should be allowed to Unstage the removal of a file. This doesn't work yet. I've added a failing test as a reminder of this.

However, I've added a shortcut method (Index.Remove()) which should act as a very basic replacement for git rm. This will remove the file from the working directory and the Index.

I've pushed a fix in the vNext branch of the nulltoken remote. Could you please check that it actually fits your need?

from libgit2sharp.

Thanks so far!

I will test it tomorrow. But it looks good so far.

from libgit2sharp.

My tests finished successfully!

Thanks a lot!

from libgit2sharp.

My tests finished successfully!

Glad your issue was fixed. The fix has been pushed up to libgit2sharp/vNext.
I'll keep this issue opened until Unstage behavior is fixed.

from libgit2sharp.

Released as part of LibGit2Sharp v0.6.0

from libgit2sharp.