Git Product home page Git Product logo

Comments (5)

nulltoken avatar nulltoken commented on May 22, 2024

Hey David,

Sorry, I completely overlooked this issue. :-(

Re-initializing is indeed not implemented yet in libgit2. Shouldn't be a big deal once libgit2 properly creates a config file.

from libgit2sharp.

sergiyb avatar sergiyb commented on May 22, 2024

Same on Repository.Discover( Path ). If Path exist but not a git repository, no exception thrown or like that, it just get freesed. Not a big deal though. So I do this:

if( Path.IsPathRooted( Path ) && Directory.Exists( Path + @".git" ) )
{
dir = Repository.Discover( Path );
}
else
{
dir = Repository.Init( Path );
}

from libgit2sharp.

nulltoken avatar nulltoken commented on May 22, 2024

@sergiyb that looks like a bug.

Could you open a separate issue concerning this weird behavior of Repository.Discover()?

I would be especially interested in the precise description of your failing case. This would allow me to create a failing test and enhance the safety net against future regressions.

Thanks in advance.

from libgit2sharp.

nulltoken avatar nulltoken commented on May 22, 2024

Fixed in 7b511cd

from libgit2sharp.

davidfowl avatar davidfowl commented on May 22, 2024

Yay :)

from libgit2sharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.