unsoundness in `extract_string` function about blazesym HOT 5 CLOSED

The allocator part is not right. This function returns a reference, not an owned object. So, there is no allocation or deallocation involved here.

For invalid UTF-8 code points, we need to handle them by either encoding them or skipping them. Or replace it with CStr.

from blazesym.

The allocator part is not right. This function returns a reference, not an owned object. So, there is no allocation or deallocation involved here.

It does not matter what the function returns. What matters is what functions are called inside it.

from blazesym.

Are you saying String::from_raw_parts(...)?

from blazesym.

According to the document.

This is highly unsafe, due to the number of invariants that aren’t checked:
....

So, it is why from_raw_parts() is unsafe. That is why leak() is there as a hack of these unchecked to avoid corruption.
However, moving to CStr is a better solution.

from blazesym.

According to the document.

This is highly unsafe, due to the number of invariants that aren’t checked:
....

So, it is why from_raw_parts() is unsafe. That is why leak() is there as a hack of these unchecked to avoid corruption. However, moving to CStr is a better solution.

Unfortunately, that's not how it works. You call the function you have to adhere to the constraints it imposes at the time you call it.

from blazesym.