Migrate from `log` to `tracing` about blazesym HOT 6 CLOSED

Hey can i work on this issue ?

Absolutely. Let me know if you have any questions, happy to provide guidance.

Thank you so i went through the codebase and we want to add #[tracing::instrument] to the logged methods right ?

from blazesym.

This issue is completed with #213 merged. Thanks again for your contribution!

from blazesym.

We likely want to migrate over to tracing, as it provides spans, which help in providing necessary context to log statements. For our intents and purposes, both are pretty much source compatible and so the switch should be close to trivial (even more so given how few log statements we have to begin with).

Hey can i work on this issue ?

from blazesym.

Hey can i work on this issue ?

Absolutely. Let me know if you have any questions, happy to provide guidance.

from blazesym.

Thank you so i went through the codebase and we want to add #[tracing::instrument] to the logged methods right ?

I think that would be a good second step and would require identifying relevant call sites and then also mocking the macro when tracing is not in use (we should keep the optionality we currently have with the log feature).

The first step is mostly just swapping out ::log:: imports with ::tracing:: and setting the appropriate features for the test-log dependency (at least that's what I can think of right now), I think.

from blazesym.

Thank you so i went through the codebase and we want to add #[tracing::instrument] to the logged methods right ?

I think that would be a good second step and would require identifying relevant call sites and then also mocking the macro when tracing is not in use (we should keep the optionality we currently have with the log feature).

The first step is mostly just swapping out ::log:: imports with ::tracing:: and setting the appropriate features for the test-log dependency (at least that's what I can think of right now), I think.

Makes sense let me get started on it

from blazesym.