Git Product home page Git Product logo

Comments (5)

niklassaers avatar niklassaers commented on June 24, 2024 1

Awesome, thank you so much :-)

from xcstrings-tool.

liamnichols avatar liamnichols commented on June 24, 2024

Thanks for reporting this! I didn't think much of it at first and TIL that it's an error in Swift 6!

I think that the issue actually comes from swift-syntax since I run the generated code through it's formatter.

When I get a chance, I'll confirm and see if the issue has been addressed there. If we need to wait until September for a patch though, I'll figure out a workaround πŸ‘

from xcstrings-tool.

niklassaers avatar niklassaers commented on June 24, 2024

Thanks for explaining where it comes from. I pointed the build at the swift-syntax main branch instead of the pinned version and it seems to be resolved there. Here's the output from two of the tests included in xcstrings-tool:

     /// Creates a text view that displays a localized string defined in the β€˜Localizableβ€˜ strings table.
     public init(localizable: String.Localizable) {
βˆ’        if #available (macOS 13, iOS 16, tvOS 16, watchOS 9, *) {
+        if #available(macOS 13, iOS 16, tvOS 16, watchOS 9, *) {
             self.init(LocalizedStringResource(localizable: localizable))
             return
         }

and

         /// %lld: People liked %lld posts
         /// ```
βˆ’        @available (*, deprecated, message: "Use `String.Localizable.mySubstitute(_:count:)` instead. This method will be removed in the future.")
+        @available(*, deprecated, message: "Use `String.Localizable.mySubstitute(_:count:)` instead. This method will be removed in the future.")
         public func mySubstitute(_ arg1: Int, count arg2: Int) -> LocalizedStringResource {
             LocalizedStringResource(localizable: .mySubstitute(arg1, count: arg2))
         }

from xcstrings-tool.

liamnichols avatar liamnichols commented on June 24, 2024

Thanks for conforming this! Since SwiftSyntax 600.0.0 isn't going to be tagged and released until September (I assume), i'm going to push up a patch that works with older versions in the meantime.

from xcstrings-tool.

liamnichols avatar liamnichols commented on June 24, 2024

Thanks for reporting this @niklassaers, it was resolved in 0.5.1 which has just been released πŸ™

from xcstrings-tool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.