Git Product home page Git Product logo

Comments (9)

liabru avatar liabru commented on May 18, 2024

when the window is being resized that maximum height does not change until a certain amount of time has passed (80ms by default)

This is a fair point, one thing I should do is fix it so the first update is immediate!

Set the items' height to auto when a resize event occurs and when the actual resize stops, calculate the max height and set it on every item.

Have you tried this? I'm sure I have in the past. I remember the problem with setting auto is that grid items will jump from being even height to uneven height during the resize and then back to even again. I think I also tried using min-height but that has other problems.

The result appears far worse than slightly sluggish updating surely?
Or am I missing something?

from jquery-match-height.

tubalmartin avatar tubalmartin commented on May 18, 2024

The result appears far worse than slightly sluggish updating surely?

Well, at least in my scenario it does. Thumbnails would appear stacked one on top of the other when resizing down (this is the column configuration for each thumbnail in a single row: col-xs-12 col-sm-6 col-md-4 col-lg-4).

Have you tried this?

Yep, extensively. But it may depend on each scenario. Either technique you choose will show a different layout to the user while resizing so it's a matter of choosing the "best" one for your scenario.

I guess to get the best of both worlds you could give users the option to set the height to auto on resize.

from jquery-match-height.

liabru avatar liabru commented on May 18, 2024

I think it will depend on scenario, do you mind supplying a jsfiddle with your use case?

from jquery-match-height.

 avatar commented on May 18, 2024

I was able to reproduce this issue in Safari with responsive designs.
http://jsfiddle.net/jonnysynthetic/o2L8uzdd/
You will need to change the width of the rendered view, and reload at different widths to see what I am talking about.
Firefox and Chrome work fine on OSX.

from jquery-match-height.

liabru avatar liabru commented on May 18, 2024

@steamsynthetic I'm unable to test on Safari, can you explain what the issue is?

from jquery-match-height.

 avatar commented on May 18, 2024

I uploaded a screen cast.
In the first situation, it works properly. In the second situation (after reload) it does not. I have also noticed that in multiple reloads, it doesn't always calculate the height correctly.

I apologize in advance, Screencast isn't the fastest to load videos.
http://screencast.com/t/ZuynFBfTT8u

from jquery-match-height.

liabru avatar liabru commented on May 18, 2024

Thanks for the screen cast.

Are you sure this is related to the OP's suggestion (which isn't an actual bug I think)?

To me it looks unrelated, because it appears to be an actual failure of the plugin in Safari?
If so could you open a new issue for this?

from jquery-match-height.

 avatar commented on May 18, 2024

I figured it was related because if it recalculated the height to auto on resize, it would probably fix this issue. But I will do that as well.

from jquery-match-height.

liabru avatar liabru commented on May 18, 2024

Closing this one, as the suggestion seems to only work under a very specific scenario from what I can tell.

from jquery-match-height.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.