Compile on versions less than 17.0 failing about lfe HOT 6 CLOSED

@rvirding Is there anything I can do to help debug/fix this?

As a result of this issue, all of my non-17.0 builds on Travis CI are failing :-(

from lfe.

I will copy my comment in #erlang-lisp:

The problem with maps is twofold:
A number of calls to the bif is_map/1 type test and some some record definitions of maps for Core erlang. Calls to the maps module are no problem as these will just fail. If there was a decent way of testing which version of Erlang was being used there would be no problems as I could define macros. Maybe make should should first run an erlang to write something into a file which could then be used to define the right macros.

A solution is to maybe have separate branches, for a while anyway. So master and develop would support R15,16 while maps-dev would be for R17?

Saw your questions last night but net connection went down before I could reply. I run a wifi hotspot in my mobile out in the country so it is not that reliable.

from lfe.

Oh dear! Yeah, we never saw this comment on IRC yesterday. No worries, though :-) Thank goodness for other options when a network is misbehaving ;-)

Could you do a version check by calling out to erl -eval "io:format(\"~p~n\", [erlang:system_info(otp_release)]." in the Makefile?

Hrm, we could use the classic autoconfig approach: run ./config to generate a Makefile from a Makefile.in ...

If none of these work, I'm perfectly okay with just master and develop -- I can update all the docs and scripts to point to master; develop can be where all the breaking changes happen (which was probably your original intent anyway! See what happens when you do such a good job of making develop stable? ;-)).

If we go down this route, ultimately, backwards incompatible changes will make it into master, but we can alleviate a bad user experience with documentation. For example, we could have a section of the README dedicated to helping users figure out which version of LFE would work for them, which ones mapped to which versions of Erlang/OTP, and how to checkout from tags (e.g., git clone http://github.com/rvirding/lfe && cd lfe && git checkout tags/v0.8). Hrm, I guess I could also add a --use-version flag to lfetool to do something similar.

from lfe.

Added a commit cb26eda to the 'develop' branch which checks for existence of maps and creates a file "maps.mk" which is included by make. The file contains definition of a HAS_MAPS macro which is tested in the relevant files. I don't quite understand why make can load a file like this but it works. "make clean" removes file.

THIS ONLY WORKS WITH MAKE AND NOT WITH REBAR!

from lfe.

Hurray! This has fixed all the broken builds in TravisCI!

I didn't even have to update lfetool with a release. So magical :-)

from lfe.

Thanks again!

from lfe.