Pattern matching of binary argument works in REPL but does not compile about lfe HOT 9 CLOSED

This is a bug which I will fix real soon now. It has also come up in the slack #general channel. There is a quick fix which works in the REPL and the compiler, and is actually fully legal as well 😄

(defun chop
  (((binary ("xyz") (more binary)))
    (io:format "CHOP: ~p~n" `(,more)))

  ((_)                         ;Note the _ here to match all
    'nochop))

from lfe.

Thanks for filing this ticket ... we should have done so when this came up a while back, and again when it came up a few weeks ago :-)

from lfe.

This should now work as expected after a commit in develop. I will merge this into master RSN if no one finds any serious errors.

from lfe.

Closing since the fix is now merged ...

(@dendrown btw, that rebar3_lfe bug is now fixed 😄)

from lfe.

Thank you. I'm very glad to see there's a nice work-around while waiting on the fix.

@rvirding : thanks also for the note about the underscore. Somewhere along the line I got the idea that an LFE hyphen was like an Erlang underscore.

from lfe.

Thanks, Robert. I verified that this fixes the toy example. I'm still having a problem in the actual project.

Yet, this may now likely be a rebar3_lfe plugin issue. Even though I've deleted lfe from the plugin's cache and then watched it pull & rebuild the updated lfe develop branch, I'm still getting the error. However, if I call lfec from the plugin's cache to compile the module individually, I get no error. Also, if I compile the module from the repl, there's no error.

Note that the project still builds fine when I have the work-around you mentioned in place. So, I'm not stopped.at all. In fact, a couple of weeks ago I rewrote that module in Erlang, so I could move forward. Now, I've reinstated the LFE version in the project.

from lfe.

@dendrown do you still have this problem? If so could you give me an example of how it happens?

from lfe.

Hi @rvirding . I just went back and took out the work-around in the larger project, and things look good. The code compiles and works as expected. I'm on LFE v2.0.1.

Just note that I'm still using rebar v3.14.1, and I haven't dared to upgrade since I found the lfe_rebar3#68 issue I referenced above.

from lfe.

Thanks @rvirding and @oubiwann !!

from lfe.