Typings for `client` object are incorrect about next-with-apollo HOT 4 CLOSED

Right, you may want to do this:

withApollo({
  client: ({ link }) => ({
    link: link as ApolloLink,
    cache: new InMemoryCache()
  }),
  link: {
    http: new HttpLink({
      uri: GRAPHQL_URL
    })
  }
})

Two things to notice:

First that I'm adding link, I'm already doing that by default but ApolloClientOptions requires link to be present, I don't know what to do there actually, I don't want to clone ApolloClientOptions but I want to use it, so it gives proper type checking.

Second that I'm using link as ApolloLink, that's because of this: { headers?: IncomingHttpHeaders; link?: ApolloLink }, link? is undefined when you're returning an ApolloClient directly and not using the custom link (the one that has http, ws, setContext), but in this case it's always defined.

If you know how can I improve the types, specially for the second part, it would be awesome 👍

from next-with-apollo.

I created a new branch v2.2 that fixes this issues by accepting an ApolloClient directly into withApollo or a function that returns an ApolloClient or (this case) an object that uses client and link to build the ApolloClient, it's backwards compatible unless you're using typescript, let me know what you think, and if it should be a 3.0 instead

from next-with-apollo.

Thanks so much! Yeah I guess this would be a v3 since it is breaking?

from next-with-apollo.

Yes, I'm having a discussion about 3.0 with myself here, feel free to join, I would like a second opinion

from next-with-apollo.