Comments (2)
Thanks for reporting! Will get my hands on it soon.
from pasvl.
Hey @Averor !
I spent a couple of hours thinking about this problem. I agree with your suggestion to improve regex with [^)]+
. It definitely solves the problem of multiple sub-validators.
As you correctly mentioned in the end, another test failed because it uses parenthesis within the regular expression:
:string :regex(/so(me|ar)/,(((12))
. The only "quick" fix I came up with was to add possibility to escape "closing parenthesis" like this: \)
. So the mentioned example became: :string :regex(/so(me|ar\)/,(((12\))
Now tests look green and probably I will merge this solution to master next week. However, the abovementioned solution is not "the best out there" and I hope to find a better one.
Let me know if you have other ideas of solving this issue.
from pasvl.
Related Issues (9)
- Enrich messaging HOT 1
- Null or shape? HOT 5
- Matching only a subset HOT 2
- Add combinations of validators HOT 2
- Review Unicode support HOT 2
- object(nullable) with subvalidators fails HOT 3
- Simple regex doesn't match HOT 4
- Validation failed with number HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pasvl.