Git Product home page Git Product logo

Comments (1)

lewissbaker avatar lewissbaker commented on May 18, 2024

I've decided instead to have when_all_ready return an aggregate of when_all_task<T> objects that encapsulates the coroutine that was used to await each of the input awaitables.

See commit c2576ad for the implementation of this (currently on the generic_ops branch).

The benefit of this approach is that we don't need to worry about potential exceptions in copying the results into separate expected<T> object or allocate a separate std::vector<expected<T>> for holding results (which could also potentially fail).

The when_all_task<T>::result() method already lets the caller obtain either a value or rethrow the exception. It can just return a reference to the exact object that was returned from the co_await expression. If the caller then wants to make a copy of the result then they can do so.

Currently, the when_all_task<T> class lives in the cppcoro::detail namespace.
If it's going to be part of the public API for cppcoro we should probably move it out of the detail namespace.

from cppcoro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.