Possible memory leak in getMany? about leveldown HOT 6 CLOSED

I've had a look around. I think its the cache - it appears to be filled up with pointers.

There is a clean up if there is a non-notfound-error , but nothing to clear out the cache if its still populated by the time of the destructor

presumably the fix is

~GetManyWorker() {
    delete keys_;
  
    for (const std::string* value: cache_) {
      if (value != NULL) delete value;
    }
}

from leveldown.

We also delete it on success:

from leveldown.

missed that - hmm well no idea then. :/

from leveldown.

@miguelmota I think you should keep your test script running longer (with 100-1000 iterations instead of 10), you might see that memory usage stabilizes over time. Garbage collection isn't deterministic and it won't collect everything immediately.

from leveldown.

I think you're right

Closing issue since it's a false lead

from leveldown.

Found a leak after all: #804

from leveldown.