Git Product home page Git Product logo

Comments (2)

soywod avatar soywod commented on June 9, 2024

The problem comes from:

fn is_valid_atom_char(c: u8) -> bool {

According to the RFC, an Atom can be a simple atom (everything except white space, controls and specials) or a dot-atom (an atom followed by 0 or more .atom). With the actual code, a space makes the is_valid_atom_char function return true which leads to this issue I opened, and a dot makes the function return false where it should return true when matching a dot-atom.

In my opinion, a lib like https://github.com/zesterer/chumsky would help a lot to parse such complex atoms (and to parse mailboxes in general, which would make the code more readable instead of manually parsing them). I will propose you a POC (only on this atoms section) so we can discuss about it and see.

from lettre.

soywod avatar soywod commented on June 9, 2024

In fact I was wrong, white spaces are valid around atoms, which makes the address John Smith <john.smith@localhost> totally valid. The problems comes from the parser I use (mailparse), somehow it cannot parse a mail with such an address.

from lettre.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.