Git Product home page Git Product logo

Comments (5)

tdelmas avatar tdelmas commented on May 12, 2024 1

I confirm I see that problem. Maybe the background of the div containing all the logo could be set to white ? (I had to look at my screen from an odd angle to see the animation of your gif...)

from website.

tdelmas avatar tdelmas commented on May 12, 2024

To make the problem more visible I changed the background:

image

One possible fix could be to force white background for these images. It will still clash with the body background on some screens, but at least it will be consistent (and simpler than requesting new images with transparent background)

from website.

bdaehlie avatar bdaehlie commented on May 12, 2024

Here's the history of the inconsistency...

Each sponsor image comes in two sizes, big and small. Small is used for the main page of the website. We used to use transparent backgrounds for both sizes, but at some point we switched to white backgrounds for the smaller images to make their size smaller.

I'm not sure what the best path forward is since it's a lot of work to make these from the original source files, making sure the clipping and dimensions are correct and the resizing looks good.

from website.

tdelmas avatar tdelmas commented on May 12, 2024

So I think the short-term fix of a simple CSS rule to force white background for these image is the good path forward, so, in case we change our mind, it'll be easier.

img.donor {
  background-color: #ffffff;
}

from website.

bdaehlie avatar bdaehlie commented on May 12, 2024

Sounds good to me

from website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.