Git Product home page Git Product logo

Comments (3)

lestrrat avatar lestrrat commented on June 1, 2024

Ooh ouch. If you have PRs, let me know. Otherwise failing tests would be much appreciated

from jwx.

BenderScript avatar BenderScript commented on June 1, 2024

Yes, I will submit a new PR shortly. I added a new test that covers these issues. BTW, what do you feel about files like option.go that have 0% percent coverage? Or functions like (k *SymmetricKey) UnmarshalJSON() that are not used and have 0% coverage?

In order to use this JWX library in the project I work I would need to remove them. I can remove in a copy of this repo or submit a PR here. Files and functions without coverage will not pass security audit...and leave me wake at night (;-)

from jwx.

lestrrat avatar lestrrat commented on June 1, 2024

Well, that's something which I can probably rectify. Please let me know what you need (coverage goal? something else) in a separate issue.

from jwx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.